Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: lib/src/executable.dart

Issue 1124113002: Add a flag controlling how verbose stack traces are. (Closed) Base URL: git@github.com:dart-lang/test.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/backend/metadata.dart ('k') | lib/src/frontend/future_matchers.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/executable.dart
diff --git a/lib/src/executable.dart b/lib/src/executable.dart
index f2f8c3c12cc6c8dff296065c59578587120f0836..6b1c4ab73635b297d6fe173b44fb116f415f42c5 100644
--- a/lib/src/executable.dart
+++ b/lib/src/executable.dart
@@ -15,6 +15,7 @@ import 'package:args/args.dart';
import 'package:stack_trace/stack_trace.dart';
import 'package:yaml/yaml.dart';
+import 'backend/metadata.dart';
import 'backend/test_platform.dart';
import 'runner/reporter/compact.dart';
import 'runner/reporter/expanded.dart';
@@ -116,6 +117,8 @@ void main(List<String> args) {
'compact': 'A single line, updated continuously.',
'expanded': 'A separate line for each update.'
});
+ _parser.addFlag("verbose-trace", negatable: false,
+ help: 'Whether to emit stack traces with core library frames.');
_parser.addFlag("color", defaultsTo: null,
help: 'Whether to use terminal colors.\n(auto-detected by default)');
@@ -161,11 +164,13 @@ transformers:
}
}
+ var metadata = new Metadata(verboseTrace: options["verbose-trace"]);
var platforms = options["platform"].map(TestPlatform.find);
var loader = new Loader(platforms,
pubServeUrl: pubServeUrl,
packageRoot: options["package-root"],
- color: color);
+ color: color,
+ metadata: metadata);
var concurrency = _defaultConcurrency;
if (options["concurrency"] != null) {
@@ -249,10 +254,16 @@ transformers:
}
var reporter = options["reporter"] == "compact"
- ? new CompactReporter(flatten(suites),
- concurrency: concurrency, color: color)
- : new ExpandedReporter(flatten(suites),
- concurrency: concurrency, color: color);
+ ? new CompactReporter(
+ flatten(suites),
+ concurrency: concurrency,
+ color: color,
+ verboseTrace: options["verbose-trace"])
+ : new ExpandedReporter(
+ flatten(suites),
+ concurrency: concurrency,
+ color: color,
+ verboseTrace: options["verbose-trace"]);
// Override the signal handler to close [reporter]. [loader] will still be
// closed in the [whenComplete] below.
« no previous file with comments | « lib/src/backend/metadata.dart ('k') | lib/src/frontend/future_matchers.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698