Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 1124093008: X87: New hydrogen instruction to reduce cost of growing an array on keyed stores. (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: New hydrogen instruction to reduce cost of growing an array on keyed stores. port 3bce9c3afbe792167a54db49b16679289e0aea8f (r28359). original commit message: HMaybeGrowElements moves the situation where you actually have to grow into deferred code. This means crankshaft doesn't have to spill registers just to make the bounds comparison to see if it'll need to grow or not. It makes the growing case a bit more expensive, but reduces the cost of the general case. BUG= Committed: https://crrev.com/3ba6783565739907f7d96c3bfaae283a0ce1b353 Cr-Commit-Position: refs/heads/master@{#28388}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +91 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +23 lines, -0 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
chunyang.dai
PTAL.
5 years, 7 months ago (2015-05-13 10:28:46 UTC) #3
Weiliang
lgtm
5 years, 7 months ago (2015-05-13 10:36:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124093008/20001
5 years, 7 months ago (2015-05-13 10:36:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-13 11:16:29 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 11:16:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ba6783565739907f7d96c3bfaae283a0ce1b353
Cr-Commit-Position: refs/heads/master@{#28388}

Powered by Google App Engine
This is Rietveld 408576698