Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1124083004: Add a field trial to enable out-of-process V8 pac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment and rebase. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/net/proxy_service_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 482 matching lines...) Expand 10 before | Expand all | Expand 10 after
493 switches::kSupervisedUserSafeSites, 493 switches::kSupervisedUserSafeSites,
494 "disabled" }, 494 "disabled" },
495 { IDS_SUPERVISED_USER_SAFESITES_BLACKLIST_ONLY, 495 { IDS_SUPERVISED_USER_SAFESITES_BLACKLIST_ONLY,
496 switches::kSupervisedUserSafeSites, 496 switches::kSupervisedUserSafeSites,
497 "blacklist-only" }, 497 "blacklist-only" },
498 { IDS_SUPERVISED_USER_SAFESITES_ONLINE_CHECK_ONLY, 498 { IDS_SUPERVISED_USER_SAFESITES_ONLINE_CHECK_ONLY,
499 switches::kSupervisedUserSafeSites, 499 switches::kSupervisedUserSafeSites,
500 "online-check-only" } 500 "online-check-only" }
501 }; 501 };
502 502
503 const Experiment::Choice kV8PacChoices[] = {
504 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
505 { IDS_GENERIC_EXPERIMENT_CHOICE_ENABLED,
506 switches::kV8PacMojoOutOfProcess,
507 "enabled" },
508 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
509 switches::kDisableOutOfProcessPac,
510 "disabled" }
511 };
512
503 // RECORDING USER METRICS FOR FLAGS: 513 // RECORDING USER METRICS FOR FLAGS:
504 // ----------------------------------------------------------------------------- 514 // -----------------------------------------------------------------------------
505 // The first line of the experiment is the internal name. If you'd like to 515 // The first line of the experiment is the internal name. If you'd like to
506 // gather statistics about the usage of your flag, you should append a marker 516 // gather statistics about the usage of your flag, you should append a marker
507 // comment to the end of the feature name, like so: 517 // comment to the end of the feature name, like so:
508 // "my-special-feature", // FLAGS:RECORD_UMA 518 // "my-special-feature", // FLAGS:RECORD_UMA
509 // 519 //
510 // After doing that, run 520 // After doing that, run
511 // tools/metrics/actions/extract_actions.py 521 // tools/metrics/actions/extract_actions.py
512 // to add the metric to actions.xml (which will enable UMA to record your 522 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1813 matching lines...) Expand 10 before | Expand all | Expand 10 after
2326 IDS_FLAGS_OZONE_TEST_SINGLE_HARDWARE_OVERLAY_DESCRIPTION, 2336 IDS_FLAGS_OZONE_TEST_SINGLE_HARDWARE_OVERLAY_DESCRIPTION,
2327 kOsCrOS, 2337 kOsCrOS,
2328 SINGLE_VALUE_TYPE(switches::kOzoneTestSingleOverlaySupport) 2338 SINGLE_VALUE_TYPE(switches::kOzoneTestSingleOverlaySupport)
2329 }, 2339 },
2330 #endif // defined(OS_CHROMEOS) && defined(USE_OZONE) 2340 #endif // defined(OS_CHROMEOS) && defined(USE_OZONE)
2331 { 2341 {
2332 "v8-pac-mojo-out-of-process", 2342 "v8-pac-mojo-out-of-process",
2333 IDS_FLAGS_V8_PAC_MOJO_OUT_OF_PROCESS_NAME, 2343 IDS_FLAGS_V8_PAC_MOJO_OUT_OF_PROCESS_NAME,
2334 IDS_FLAGS_V8_PAC_MOJO_OUT_OF_PROCESS_DESCRIPTION, 2344 IDS_FLAGS_V8_PAC_MOJO_OUT_OF_PROCESS_DESCRIPTION,
2335 kOsDesktop, 2345 kOsDesktop,
2336 SINGLE_VALUE_TYPE(switches::kV8PacMojoOutOfProcess), 2346 MULTI_VALUE_TYPE(kV8PacChoices),
Alexei Svitkine (slow) 2015/05/15 14:33:42 Nit: Use ENABLE_DISABLE_VALUE_TYPE() instead.
Anand Mistry (off Chromium) 2015/05/15 18:47:58 Done.
2337 }, 2347 },
2338 #if defined(ENABLE_MEDIA_ROUTER) 2348 #if defined(ENABLE_MEDIA_ROUTER)
2339 { 2349 {
2340 "enable-media-router", 2350 "enable-media-router",
2341 IDS_FLAGS_ENABLE_MEDIA_ROUTER_NAME, 2351 IDS_FLAGS_ENABLE_MEDIA_ROUTER_NAME,
2342 IDS_FLAGS_ENABLE_MEDIA_ROUTER_DESCRIPTION, 2352 IDS_FLAGS_ENABLE_MEDIA_ROUTER_DESCRIPTION,
2343 kOsAll, 2353 kOsAll,
2344 SINGLE_VALUE_TYPE(switches::kEnableMediaRouter) 2354 SINGLE_VALUE_TYPE(switches::kEnableMediaRouter)
2345 }, 2355 },
2346 #endif // defined(ENABLE_MEDIA_ROUTER) 2356 #endif // defined(ENABLE_MEDIA_ROUTER)
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
2997 } 3007 }
2998 3008
2999 const Experiment* GetExperiments(size_t* count) { 3009 const Experiment* GetExperiments(size_t* count) {
3000 *count = num_experiments; 3010 *count = num_experiments;
3001 return experiments; 3011 return experiments;
3002 } 3012 }
3003 3013
3004 } // namespace testing 3014 } // namespace testing
3005 3015
3006 } // namespace about_flags 3016 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/net/proxy_service_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698