Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1124073003: Add gfx_unittests target to the list of Android stable test suites. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, alokp, Dirk Pranke, Sami
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put gfx_unittests target to run in the Android FYI bots first. Reported in https://groups.google.com/a/chromium.org/d/topic/chromium-dev/i_FsP_dlFg4/discussion. BUG= TEST= R=jbudorick@chromium.org Committed: https://crrev.com/43d9353ec936afddf5a02e600e760843db9f0d5b Cr-Commit-Position: refs/heads/master@{#329184}

Patch Set 1 #

Patch Set 2 : Android FYI bot changes #

Total comments: 2

Patch Set 3 : REBASE + VALID_TESTS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M build/android/buildbot/bb_device_steps.py View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M build/android/buildbot/bb_run_bot.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
jbudorick
Note that this change will add gfx_unittests to many of the FYI bots, though not ...
5 years, 7 months ago (2015-05-11 13:19:54 UTC) #1
tfarina
John, could you please, take another look at patch set 2? Where do I use ...
5 years, 7 months ago (2015-05-11 15:58:26 UTC) #2
jbudorick
re trial_tests: rebase beyond https://chromium.googlesource.com/chromium/src/+/8548f23eda31681228a82413194711844c886870 and add gfx_unittests to the trial_tests list added in that ...
5 years, 7 months ago (2015-05-11 16:03:42 UTC) #3
tfarina
PTAL https://codereview.chromium.org/1124073003/diff/20001/build/android/buildbot/bb_device_steps.py File build/android/buildbot/bb_device_steps.py (right): https://codereview.chromium.org/1124073003/diff/20001/build/android/buildbot/bb_device_steps.py#newcode97 build/android/buildbot/bb_device_steps.py:97: VALID_TESTS = set(['chromedriver', 'chrome_proxy', 'components_browsertests', On 2015/05/11 16:03:42, ...
5 years, 7 months ago (2015-05-11 16:35:18 UTC) #4
jbudorick
lgtm
5 years, 7 months ago (2015-05-11 16:36:18 UTC) #5
tfarina
CL description updated. Thanks for reviewing this John. Pushing to CQ.
5 years, 7 months ago (2015-05-11 16:38:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124073003/40001
5 years, 7 months ago (2015-05-11 16:56:46 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-11 18:04:17 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:06:21 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/43d9353ec936afddf5a02e600e760843db9f0d5b
Cr-Commit-Position: refs/heads/master@{#329184}

Powered by Google App Engine
This is Rietveld 408576698