Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1124063004: [CSS Grid Layout] Implement CSSGridTemplateAreasValue::equals (Closed)

Created:
5 years, 7 months ago by Manuel Rego
Modified:
5 years, 7 months ago
CC:
blink-reviews, jfernandez, svillar, blink-reviews-css, Manuel Rego, dglazkov+blink, apavlov+blink_chromium.org, darktears, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] Implement CSSGridTemplateAreasValue::equals This was causing an infinite loop setting grid-template shorthand from JavaScript. The reason was that CSSGridTemplateAreasValue needs an specific implementation of equals() method. BUG=485984 TEST=fast/css-grid-layout/grid-template-shorthand-infinite-loop.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
A LayoutTests/fast/css-grid-layout/grid-template-shorthand-infinite-loop.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/fast/css-grid-layout/grid-template-shorthand-infinite-loop-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/CSSGridTemplateAreasValue.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Manuel Rego
5 years, 7 months ago (2015-05-12 13:42:33 UTC) #2
Timothy Loh
On 2015/05/12 13:42:33, Manuel Rego wrote: lgtm
5 years, 7 months ago (2015-05-13 00:46:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124063004/1
5 years, 7 months ago (2015-05-13 04:07:43 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 05:47:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195295

Powered by Google App Engine
This is Rietveld 408576698