Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1124053006: Use StringPairs with SplitStringIntoKeyValuePairs in google_apis (Closed)

Created:
5 years, 7 months ago by packland
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StringPairs with SplitStringIntoKeyValuePairs in google_apis BUG=412250 Committed: https://crrev.com/6a33233bf28ef841648e6c9826fa52681c6246cc Cr-Commit-Position: refs/heads/master@{#329910}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M google_apis/gaia/gaia_auth_fetcher.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
packland
Please take a look, thank you
5 years, 7 months ago (2015-05-13 18:56:06 UTC) #2
packland
Hello, please have a look. Thank you.
5 years, 7 months ago (2015-05-14 18:31:58 UTC) #4
Roger Tawa OOO till Jul 10th
lgtm
5 years, 7 months ago (2015-05-14 18:55:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124053006/1
5 years, 7 months ago (2015-05-14 18:58:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 19:55:42 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 19:57:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a33233bf28ef841648e6c9826fa52681c6246cc
Cr-Commit-Position: refs/heads/master@{#329910}

Powered by Google App Engine
This is Rietveld 408576698