Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/analyzer/lib/src/task/manager.dart

Issue 1124003007: In the new task model, use explicit dependencies on the type provider. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Reformat Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/task/manager.dart
diff --git a/pkg/analyzer/lib/src/task/manager.dart b/pkg/analyzer/lib/src/task/manager.dart
index eebc08491fdea0fa1ef13f0b43babc5de5cf7d7a..64b8055eff42b70f4d70ba848e0f30fe3c7c36ea 100644
--- a/pkg/analyzer/lib/src/task/manager.dart
+++ b/pkg/analyzer/lib/src/task/manager.dart
@@ -33,6 +33,13 @@ class TaskManager {
Set<ResultDescriptor> priorityResults = new Set<ResultDescriptor>();
/**
+ * Indicates whether any tasks are currently being performed (or building
+ * their inputs). In debug builds, we use this to ensure that tasks don't
+ * try to make use of the task manager in reentrant fashion.
+ */
+ bool isTaskRunning = false;
scheglov 2015/05/13 21:49:09 I'm not sure that this is the best place for this
Paul Berry 2015/05/14 17:11:01 Where do you think would be better? I'm open to s
scheglov 2015/05/14 17:13:04 Maybe WorkOrder or AnalysisDriver.
Paul Berry 2015/05/14 17:27:33 WorkOrder doesn't work because we create fresh wor
+
+ /**
* Add the given [result] to the list of results that are to be computed for
* all sources within an analysis root.
*/

Powered by Google App Engine
This is Rietveld 408576698