Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1124003003: [Android] Fix iteration in GinJavaBridgeDispatcherHost::RemoveHolderAndAdvanceLocked (Closed)

Created:
5 years, 7 months ago by mnaganov (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Fix iteration in GinJavaBridgeDispatcherHost::RemoveHolderAndAdvanceLocked Make sure that iterator is always updated to point to the next element. BUG=484927 Committed: https://crrev.com/cf4a81913bc377473f3bfdf9fed67da3208ca79f Cr-Commit-Position: refs/heads/master@{#328544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
mnaganov (inactive)
*facepalm*
5 years, 7 months ago (2015-05-06 01:13:02 UTC) #2
Torne
I didn't spot it either when I reviewed the original CL, so whoops. LGTM.
5 years, 7 months ago (2015-05-06 10:35:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124003003/1
5 years, 7 months ago (2015-05-06 15:17:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 16:03:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf4a81913bc377473f3bfdf9fed67da3208ca79f Cr-Commit-Position: refs/heads/master@{#328544}
5 years, 7 months ago (2015-05-06 16:04:37 UTC) #7
sgurun-gerrit only
On 2015/05/06 16:04:37, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 7 months ago (2015-05-06 18:55:02 UTC) #8
mnaganov (inactive)
5 years, 7 months ago (2015-05-06 19:25:34 UTC) #9
Message was sent while issue was closed.
On 2015/05/06 18:55:02, sgurun wrote:
> On 2015/05/06 16:04:37, I haz the power (commit-bot) wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/cf4a81913bc377473f3bfdf9fed67da3208ca79f
> > Cr-Commit-Position: refs/heads/master@{#328544}
> 
> would it be possible to write a test for this?

Should be. I was just so much excited about finding and fixing the bug that
totally forgot about the not so much exciting part of writing a regression test.

Powered by Google App Engine
This is Rietveld 408576698