Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1124003002: Revert of Make drawImage a virtual on SkDevice (Closed)

Created:
5 years, 7 months ago by reed2
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make drawImage a virtual on SkDevice (patchset #4 id:60001 of https://codereview.chromium.org/1122643005/) Reason for revert: speculative to see if it unblocks DEPS roll Original issue's description: > Make drawImage a virtual on SkDevice > > Now with patch for SkDeferredCanvas > > This reverts commit 119468b71f8f4f45657ab30ead331be665de5a57. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/14fe8fd3e53b5e988aac189a8bc3ed28904d85c8 TBR=robertphillips@google.com,mtklein@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -356 lines) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +13 lines, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +5 lines, -51 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M src/core/SkPaintPriv.h View 2 chunks +5 lines, -7 lines 0 comments Download
M src/core/SkPaintPriv.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +0 lines, -42 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +13 lines, -0 lines 0 comments Download
M src/pipe/SkGPipePriv.h View 4 chunks +0 lines, -20 lines 0 comments Download
M src/pipe/SkGPipeRead.cpp View 7 chunks +1 line, -46 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 7 chunks +5 lines, -89 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 5 chunks +7 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
reed2
Created Revert of Make drawImage a virtual on SkDevice
5 years, 7 months ago (2015-05-06 00:30:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124003002/1
5 years, 7 months ago (2015-05-06 00:30:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/3538e3bfe2e00bc1b5b48d977fa7adff64d8c96b
5 years, 7 months ago (2015-05-06 00:30:52 UTC) #3
reed1
5 years, 7 months ago (2015-05-06 14:54:08 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1126273002/ by reed@google.com.

The reason for reverting is: retry now that some fixes (onDrawImage overrides)
have landed in chrome/blink.

Powered by Google App Engine
This is Rietveld 408576698