Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: cc/resources/filter_display_item.h

Issue 1123983002: cc: Use a ListContainer for DisplayItemList to reduce allocations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: displaylistcontainer: fixdcheck Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/resources/drawing_display_item.cc ('k') | cc/resources/filter_display_item.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_RESOURCES_FILTER_DISPLAY_ITEM_H_ 5 #ifndef CC_RESOURCES_FILTER_DISPLAY_ITEM_H_
6 #define CC_RESOURCES_FILTER_DISPLAY_ITEM_H_ 6 #define CC_RESOURCES_FILTER_DISPLAY_ITEM_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "cc/base/cc_export.h" 9 #include "cc/base/cc_export.h"
10 #include "cc/output/filter_operations.h" 10 #include "cc/output/filter_operations.h"
11 #include "cc/resources/display_item.h" 11 #include "cc/resources/display_item.h"
12 #include "ui/gfx/geometry/rect_f.h" 12 #include "ui/gfx/geometry/rect_f.h"
13 13
14 class SkCanvas; 14 class SkCanvas;
15 class SkDrawPictureCallback; 15 class SkDrawPictureCallback;
16 16
17 namespace cc { 17 namespace cc {
18 18
19 class CC_EXPORT FilterDisplayItem : public DisplayItem { 19 class CC_EXPORT FilterDisplayItem : public DisplayItem {
20 public: 20 public:
21 FilterDisplayItem();
21 ~FilterDisplayItem() override; 22 ~FilterDisplayItem() override;
22 23
23 static scoped_ptr<FilterDisplayItem> Create(const FilterOperations& filters, 24 void SetNew(const FilterOperations& filters, const gfx::RectF& bounds);
24 gfx::RectF bounds) {
25 return make_scoped_ptr(new FilterDisplayItem(filters, bounds));
26 }
27 25
28 void Raster(SkCanvas* canvas, SkDrawPictureCallback* callback) const override; 26 void Raster(SkCanvas* canvas, SkDrawPictureCallback* callback) const override;
29 27
30 bool IsSuitableForGpuRasterization() const override; 28 bool IsSuitableForGpuRasterization() const override;
31 int ApproximateOpCount() const override; 29 int ApproximateOpCount() const override;
32 size_t PictureMemoryUsage() const override; 30 size_t PictureMemoryUsage() const override;
33 void AsValueInto(base::trace_event::TracedValue* array) const override; 31 void AsValueInto(base::trace_event::TracedValue* array) const override;
34 32
35 protected: 33 protected:
36 FilterDisplayItem(const FilterOperations& filters, gfx::RectF bounds); 34 FilterDisplayItem(const FilterOperations& filters, gfx::RectF bounds);
37 35
38 private: 36 private:
39 FilterOperations filters_; 37 FilterOperations filters_;
40 gfx::RectF bounds_; 38 gfx::RectF bounds_;
41 }; 39 };
42 40
43 class CC_EXPORT EndFilterDisplayItem : public DisplayItem { 41 class CC_EXPORT EndFilterDisplayItem : public DisplayItem {
44 public: 42 public:
43 EndFilterDisplayItem();
45 ~EndFilterDisplayItem() override; 44 ~EndFilterDisplayItem() override;
46 45
47 static scoped_ptr<EndFilterDisplayItem> Create() { 46 static scoped_ptr<EndFilterDisplayItem> Create() {
48 return make_scoped_ptr(new EndFilterDisplayItem()); 47 return make_scoped_ptr(new EndFilterDisplayItem());
49 } 48 }
50 49
51 void Raster(SkCanvas* canvas, SkDrawPictureCallback* callback) const override; 50 void Raster(SkCanvas* canvas, SkDrawPictureCallback* callback) const override;
52 51
53 bool IsSuitableForGpuRasterization() const override; 52 bool IsSuitableForGpuRasterization() const override;
54 int ApproximateOpCount() const override; 53 int ApproximateOpCount() const override;
55 size_t PictureMemoryUsage() const override; 54 size_t PictureMemoryUsage() const override;
56 void AsValueInto(base::trace_event::TracedValue* array) const override; 55 void AsValueInto(base::trace_event::TracedValue* array) const override;
57
58 protected:
59 EndFilterDisplayItem();
60 }; 56 };
61 57
62 } // namespace cc 58 } // namespace cc
63 59
64 #endif // CC_RESOURCES_FILTER_DISPLAY_ITEM_H_ 60 #endif // CC_RESOURCES_FILTER_DISPLAY_ITEM_H_
OLDNEW
« no previous file with comments | « cc/resources/drawing_display_item.cc ('k') | cc/resources/filter_display_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698