Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1320)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java

Issue 1123943002: Move SecurityLevel into a class of its own (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: register in chrome_jni_registrar Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
index 0fd6bb80215e5626c50127a0e58c9a42702572c8..806cb94eabe327f85eb7ae1c09a4fbac18839222 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java
@@ -41,8 +41,9 @@ import org.chromium.base.CalledByNative;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.omnibox.OmniboxUrlEmphasizer;
import org.chromium.chrome.browser.profiles.Profile;
+import org.chromium.chrome.browser.ssl.ConnectionSecurityHelper;
+import org.chromium.chrome.browser.ssl.ConnectionSecurityHelperSecurityLevel;
import org.chromium.chrome.browser.toolbar.ToolbarModel;
-import org.chromium.chrome.browser.ui.toolbar.ToolbarModelSecurityLevel;
import org.chromium.content_public.browser.WebContents;
import org.chromium.content_public.browser.WebContentsObserver;
import org.chromium.ui.base.Clipboard;
@@ -243,7 +244,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
// chrome://settings page).
private boolean mIsInternalPage;
- // The security level of the page (a valid ToolbarModelSecurityLevel).
+ // The security level of the page (a valid ConnectionSecurityHelperSecurityLevel).
private int mSecurityLevel;
// Whether the security level of the page was deprecated due to SHA-1.
@@ -375,7 +376,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
mParsedUrl = null;
mIsInternalPage = false;
}
- mSecurityLevel = ToolbarModel.getSecurityLevelForWebContents(mWebContents);
+ mSecurityLevel = ConnectionSecurityHelper.getSecurityLevelForWebContents(mWebContents);
mDeprecatedSHA1Present = ToolbarModel.isDeprecatedSHA1Present(mWebContents);
SpannableStringBuilder urlBuilder = new SpannableStringBuilder(mFullUrl);
@@ -433,26 +434,26 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
* Gets the message to display in the connection message box for the given security level. Does
* not apply to SECURITY_ERROR pages, since these have their own coloured/formatted message.
*
- * @param toolbarModelSecurityLevel A valid ToolbarModelSecurityLevel, which is the security
- * level of the page.
+ * @param securityLevel A valid ConnectionSecurityHelperSecurityLevel, which is the security
+ * level of the page.
* @param isInternalPage Whether or not this page is an internal chrome page (e.g. the
* chrome://settings page).
* @return The ID of the message to display in the connection message box.
*/
- private int getConnectionMessageId(int toolbarModelSecurityLevel, boolean isInternalPage) {
+ private int getConnectionMessageId(int securityLevel, boolean isInternalPage) {
if (isInternalPage) return R.string.page_info_connection_internal_page;
- switch (toolbarModelSecurityLevel) {
- case ToolbarModelSecurityLevel.NONE:
+ switch (securityLevel) {
+ case ConnectionSecurityHelperSecurityLevel.NONE:
return R.string.page_info_connection_http;
- case ToolbarModelSecurityLevel.SECURE:
- case ToolbarModelSecurityLevel.EV_SECURE:
+ case ConnectionSecurityHelperSecurityLevel.SECURE:
+ case ConnectionSecurityHelperSecurityLevel.EV_SECURE:
return R.string.page_info_connection_https;
- case ToolbarModelSecurityLevel.SECURITY_WARNING:
- case ToolbarModelSecurityLevel.SECURITY_POLICY_WARNING:
+ case ConnectionSecurityHelperSecurityLevel.SECURITY_WARNING:
+ case ConnectionSecurityHelperSecurityLevel.SECURITY_POLICY_WARNING:
return R.string.page_info_connection_mixed;
default:
- assert false : "Invalid security level specified: " + toolbarModelSecurityLevel;
+ assert false : "Invalid security level specified: " + securityLevel;
return R.string.page_info_connection_http;
}
}
@@ -462,7 +463,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
* HTTPS connections.
*/
private boolean isConnectionDetailsLinkVisible() {
- return !mIsInternalPage && mSecurityLevel != ToolbarModelSecurityLevel.NONE;
+ return !mIsInternalPage && mSecurityLevel != ConnectionSecurityHelperSecurityLevel.NONE;
}
/**
@@ -474,7 +475,7 @@ public class WebsiteSettingsPopup implements OnClickListener, OnItemSelectedList
if (mDeprecatedSHA1Present) {
messageBuilder.append(
mContext.getResources().getString(R.string.page_info_connection_sha1));
- } else if (mSecurityLevel != ToolbarModelSecurityLevel.SECURITY_ERROR) {
+ } else if (mSecurityLevel != ConnectionSecurityHelperSecurityLevel.SECURITY_ERROR) {
messageBuilder.append(mContext.getResources().getString(
getConnectionMessageId(mSecurityLevel, mIsInternalPage)));
} else {

Powered by Google App Engine
This is Rietveld 408576698