Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: tools/tickprocessor.js

Issue 1123883002: [tick processor] Introduce --pairwise-timed-range processing mode (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix typo Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/logreader.js ('k') | tools/tickprocessor-driver.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/tickprocessor.js
diff --git a/tools/tickprocessor.js b/tools/tickprocessor.js
index 05f42076bd97ffaf010f2251145bb6abb6973ad5..d8575738553aa93f46116489312232d31acf8cf5 100644
--- a/tools/tickprocessor.js
+++ b/tools/tickprocessor.js
@@ -155,7 +155,8 @@ function TickProcessor(
distortion,
range,
sourceMap,
- timedRange) {
+ timedRange,
+ pairwiseTimedRange) {
LogReader.call(this, {
'shared-library': { parsers: [null, parseInt, parseInt],
processor: this.processSharedLibrary },
@@ -193,7 +194,8 @@ function TickProcessor(
'code-allocate': null,
'begin-code-region': null,
'end-code-region': null },
- timedRange);
+ timedRange,
+ pairwiseTimedRange);
this.cppEntriesProvider_ = cppEntriesProvider;
this.callGraphSize_ = callGraphSize;
@@ -880,13 +882,16 @@ function ArgumentsProcessor(args) {
'--source-map': ['sourceMap', null,
'Specify the source map that should be used for output'],
'--timed-range': ['timedRange', true,
- 'Ignore ticks before first and after last Date.now() call']
+ 'Ignore ticks before first and after last Date.now() call'],
+ '--pairwise-timed-range': ['pairwiseTimedRange', true,
+ 'Ignore ticks outside pairs of Date.now() calls']
};
this.argsDispatch_['--js'] = this.argsDispatch_['-j'];
this.argsDispatch_['--gc'] = this.argsDispatch_['-g'];
this.argsDispatch_['--compiler'] = this.argsDispatch_['-c'];
this.argsDispatch_['--other'] = this.argsDispatch_['-o'];
this.argsDispatch_['--external'] = this.argsDispatch_['-e'];
+ this.argsDispatch_['--ptr'] = this.argsDispatch_['--pairwise-timed-range'];
};
@@ -902,17 +907,18 @@ ArgumentsProcessor.DEFAULTS = {
nm: 'nm',
range: 'auto,auto',
distortion: 0,
- timedRange: false
+ timedRange: false,
+ pairwiseTimedRange: false
};
ArgumentsProcessor.prototype.parse = function() {
while (this.args_.length) {
- var arg = this.args_[0];
+ var arg = this.args_.shift();
if (arg.charAt(0) != '-') {
- break;
+ this.result_.logFileName = arg;
+ continue;
}
- this.args_.shift();
var userValue = null;
var eqPos = arg.indexOf('=');
if (eqPos != -1) {
@@ -926,10 +932,6 @@ ArgumentsProcessor.prototype.parse = function() {
return false;
}
}
-
- if (this.args_.length >= 1) {
- this.result_.logFileName = this.args_.shift();
- }
return true;
};
@@ -954,15 +956,15 @@ ArgumentsProcessor.prototype.printUsageAndExit = function() {
ArgumentsProcessor.DEFAULTS.logFileName + '".\n');
print('Options:');
for (var arg in this.argsDispatch_) {
- var synonims = [arg];
+ var synonyms = [arg];
var dispatch = this.argsDispatch_[arg];
for (var synArg in this.argsDispatch_) {
if (arg !== synArg && dispatch === this.argsDispatch_[synArg]) {
- synonims.push(synArg);
+ synonyms.push(synArg);
delete this.argsDispatch_[synArg];
}
}
- print(' ' + padRight(synonims.join(', '), 20) + dispatch[2]);
+ print(' ' + padRight(synonyms.join(', '), 20) + " " + dispatch[2]);
}
quit(2);
};
« no previous file with comments | « tools/logreader.js ('k') | tools/tickprocessor-driver.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698