Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1123843002: Disable failing perf unit tests on chromeos. (Closed)

Created:
5 years, 7 months ago by achuithb
Modified:
5 years, 7 months ago
Reviewers:
cylee1, tbarzic
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing perf unit tests on chromeos. BUG=483212 Committed: https://crrev.com/5dfa8a66e3777efa7208dcca696ae20485b5392d Cr-Commit-Position: refs/heads/master@{#328398}

Patch Set 1 #

Patch Set 2 : do not disable any benchmarks #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M tools/perf/measurements/blink_style_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/perf/measurements/repaint_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/measurements/smoothness_unittest.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/profile_creators/cookie_profile_extender.py View 1 1 chunk +5 lines, -1 line 0 comments Download
M tools/perf/profile_creators/cookie_profile_extender_unittest.py View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
achuithb
Please take a look
5 years, 7 months ago (2015-05-05 00:12:44 UTC) #2
cylee1
On 2015/05/05 00:12:44, achuithb wrote: > Please take a look Sorry I didn't make it ...
5 years, 7 months ago (2015-05-05 06:45:50 UTC) #3
achuithb
On 2015/05/05 06:45:50, cylee1 wrote: > On 2015/05/05 00:12:44, achuithb wrote: > > Please take ...
5 years, 7 months ago (2015-05-05 17:27:26 UTC) #4
cylee1
lgtm
5 years, 7 months ago (2015-05-05 17:30:04 UTC) #5
achuithb
Toni - need committer lgtm.
5 years, 7 months ago (2015-05-05 19:11:04 UTC) #7
tbarzic
On 2015/05/05 19:11:04, achuithb wrote: > Toni - need committer lgtm. lgtm
5 years, 7 months ago (2015-05-05 19:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123843002/20001
5 years, 7 months ago (2015-05-05 19:15:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/2014)
5 years, 7 months ago (2015-05-05 19:26:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123843002/40001
5 years, 7 months ago (2015-05-05 19:31:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/2018)
5 years, 7 months ago (2015-05-05 19:37:13 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123843002/40001
5 years, 7 months ago (2015-05-05 20:29:38 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-05 20:43:32 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 20:44:32 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5dfa8a66e3777efa7208dcca696ae20485b5392d
Cr-Commit-Position: refs/heads/master@{#328398}

Powered by Google App Engine
This is Rietveld 408576698