Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 1123833003: Revert of Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.o… (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
tdresser
CC:
chromium-reviews, cbentzel+watch_chromium.org, chromoting-reviews_chromium.org, wfh+watch_chromium.org, Paweł Hajdan Jr., tracing+reviews_chromium.org, erikwright+watch_chromium.org, Mikhail
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.o… (patchset #1 id:1 of https://codereview.chromium.org/1124563003/) Reason for revert: Broke the compile because one of these CLs is already depended on (rch@'s bce10d97d6fc5233071427cf622aaad7abde9e19). Original issue's description: > Revert some other possible suspects of a 0.43% size increase of setup.exe: https://build.chromium.org/p/chromium/builders/Win/builds/31562 > > Revert "Add granular base::File tracing." > > This reverts commit a6e05c977096a03774e5406d63ad80c0166f9adc. > > Revert "Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider" > > This reverts commit bce10d97d6fc5233071427cf622aaad7abde9e19. > > Revert "Avoid unnecessary memory allocations at PlatformThread::SetName()" > > This reverts commit 4839a142bf95776323647c82ca9dc0725f7c4f15. > > TBR=tdresser@chromium.org > BUG=none > TEST=green sizes > > Committed: https://chromium.googlesource.com/chromium/src/+/c41830d6f55f85e2f5c8841db4b6ed81239b671d TBR=tdresser@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/eb1e4d1dd2511083e1d5506d1edfbdff68e133cc Cr-Commit-Position: refs/heads/master@{#328207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+515 lines, -298 lines) Patch
M base/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M base/base.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M base/files/file.h View 8 chunks +22 lines, -9 lines 0 comments Download
M base/files/file.cc View 6 chunks +19 lines, -5 lines 0 comments Download
M base/files/file_posix.cc View 18 chunks +32 lines, -5 lines 0 comments Download
A base/files/file_tracing.h View 1 chunk +68 lines, -0 lines 0 comments Download
A base/files/file_tracing.cc View 1 chunk +47 lines, -0 lines 0 comments Download
M base/files/file_win.cc View 16 chunks +38 lines, -7 lines 0 comments Download
M base/threading/platform_thread.h View 1 chunk +2 lines, -3 lines 0 comments Download
M base/threading/platform_thread_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/platform_thread_freebsd.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/platform_thread_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/threading/platform_thread_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M base/threading/platform_thread_win.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/threading/simple_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_id_name_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/thread_id_name_manager.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M base/threading/watchdog.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/threading/worker_pool_posix.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/trace_event/trace_event.h View 1 chunk +20 lines, -4 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 26 chunks +80 lines, -80 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 4 chunks +12 lines, -12 lines 0 comments Download
M net/socket/socket_test_util.cc View 10 chunks +34 lines, -18 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 15 chunks +36 lines, -82 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M remoting/base/auto_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/buffered_socket_writer_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Dan Beam
5 years, 7 months ago (2015-05-04 22:55:20 UTC) #1
Created Revert of Revert some other possible suspects of a 0.43% size increase
of setup.exe: https://build.chromium.o…

Powered by Google App Engine
This is Rietveld 408576698