Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 112383002: IDL compiler: sync Python to r163665 (Closed)

Created:
7 years ago by Nils Barth (inactive)
Modified:
7 years ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK), adamk
Visibility:
Public.

Description

IDL compiler: sync Python to r163665 Simplify invokeCallback() and support void return values for IDL callbacks https://codereview.chromium.org/111603006/ Also cleanup test cases to reflect use of void, and rename to clarify callback *interface*. BUG=239771 NOTRY=true TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163667

Patch Set 1 #

Patch Set 2 : New test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -601 lines) Patch
M Source/bindings/scripts/unstable/v8_callback_interface.py View 4 chunks +6 lines, -3 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 5 chunks +12 lines, -7 lines 0 comments Download
D Source/bindings/tests/idls/TestCallback.idl View 1 chunk +0 lines, -41 lines 0 comments Download
A + Source/bindings/tests/idls/TestCallbackInterface.idl View 2 chunks +11 lines, -9 lines 0 comments Download
M Source/bindings/tests/idls/TestObject.idl View 3 chunks +10 lines, -10 lines 0 comments Download
M Source/bindings/tests/idls/TestTypedefs.idl View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 3 chunks +9 lines, -10 lines 0 comments Download
D Source/bindings/tests/results/V8TestCallback.h View 1 chunk +0 lines, -72 lines 0 comments Download
D Source/bindings/tests/results/V8TestCallback.cpp View 1 chunk +0 lines, -249 lines 0 comments Download
A + Source/bindings/tests/results/V8TestCallbackInterface.h View 1 2 chunks +18 lines, -18 lines 0 comments Download
A + Source/bindings/tests/results/V8TestCallbackInterface.cpp View 1 4 chunks +69 lines, -69 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 4 chunks +16 lines, -18 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 17 chunks +99 lines, -87 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
7 years ago (2013-12-11 03:17:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/112383002/20001
7 years ago (2013-12-11 03:17:56 UTC) #2
commit-bot: I haz the power
Change committed as 163667
7 years ago (2013-12-11 03:18:15 UTC) #3
Nils Barth (inactive)
*ping* TBR
7 years ago (2013-12-11 08:16:14 UTC) #4
haraken
7 years ago (2013-12-11 08:19:29 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698