Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123823002: Remove ICS support from Chromium code. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, Yaron, qinmin
CC:
aboxhall+watch_chromium.org, avayvod+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, erikwright+watch_chromium.org, feature-media-reviews_chromium.org, jam, je_julie(Not used), mcasas+watch_chromium.org, nektar+watch_chromium.org, plundblad+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ICS support from Chromium code. minSkd is now 16, so we no longer need to support ICS. This code removes some of that support in base/content/media/ui. BUG=473837 Committed: https://crrev.com/8a2b2e2289ebcc051b10a239b1b7606d31abc925 Cr-Commit-Position: refs/heads/master@{#328244}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -146 lines) Patch
M base/android/java/src/org/chromium/base/AnimationFrameTimeHistogram.java View 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/MediaResourceGetter.java View 3 chunks +0 lines, -20 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/BrowserAccessibilityManager.java View 6 chunks +22 lines, -12 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanBrowserAccessibilityManager.java View 1 chunk +0 lines, -55 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/LollipopBrowserAccessibilityManager.java View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ClipboardTest.java View 3 chunks +3 lines, -10 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaResourceGetterTest.java View 1 chunk +0 lines, -18 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/AudioManagerAndroid.java View 1 chunk +0 lines, -6 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/MediaCodecBridge.java View 1 chunk +0 lines, -1 line 0 comments Download
M media/base/android/java/src/org/chromium/media/VideoCaptureAndroid.java View 1 chunk +0 lines, -4 lines 0 comments Download
M media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java View 3 chunks +3 lines, -9 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/widget/TextViewWithClickableSpans.java View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
aurimas (slooooooooow)
tedchoc for content/public/android/ and ui/android/ yfriedman for base/android/ qinmin for media/base/android/
5 years, 7 months ago (2015-05-04 21:18:20 UTC) #2
Yaron
base/android lgtm
5 years, 7 months ago (2015-05-04 21:25:13 UTC) #3
qinmin
lgtm on media/
5 years, 7 months ago (2015-05-04 21:35:55 UTC) #4
Ted C
lgtm -- content/public/android, ui/
5 years, 7 months ago (2015-05-04 22:17:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123823002/1
5 years, 7 months ago (2015-05-04 22:19:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/12716)
5 years, 7 months ago (2015-05-04 23:06:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123823002/1
5 years, 7 months ago (2015-05-05 00:03:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 01:07:50 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 01:08:40 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8a2b2e2289ebcc051b10a239b1b7606d31abc925
Cr-Commit-Position: refs/heads/master@{#328244}

Powered by Google App Engine
This is Rietveld 408576698