runtime/bin/process_macos.cc - Issue 11238057: Change Process.kill to return a boolean instead of throwing an exception when kill fails.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_macos.cc

Issue 11238057: Change Process.kill to return a boolean instead of throwing an exception when kill fails. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/process_macos.cc

diff --git a/runtime/bin/process_macos.cc b/runtime/bin/process_macos.cc

index 20d12870241019190e70dd83ff8ca55d3027c962..b23ab169c394993e3df69baaa88df1f44857ad7b 100644

--- a/runtime/bin/process_macos.cc

+++ b/runtime/bin/process_macos.cc

@@ -551,11 +551,7 @@ int Process::Start(const char* path,

bool Process::Kill(intptr_t id, int signal) {

- int result = TEMP_FAILURE_RETRY(kill(id, signal));

- if (result == -1) {

- return false;

- }

- return true;

+ return (TEMP_FAILURE_RETRY(kill(id, signal)) != -1);

}

« no previous file with comments | « runtime/bin/process_linux.cc ('k') | runtime/bin/process_win.cc » ('j') | no next file with comments »