chrome/test/data/extensions/platform_apps/minimal_id/test.js - Issue 11238055: Re-open DevTools windows for PackagedApps if they are reloaded with DevTools open.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/minimal_id/test.js

Issue 11238055: Re-open DevTools windows for PackagedApps if they are reloaded with DevTools open. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: more encapsulation, self-nit unit test code, add expected FAILS_ for debug builds Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/data/extensions/platform_apps/minimal_id/test.js

diff --git a/chrome/browser/resources/settings_app/settings_app.js b/chrome/test/data/extensions/platform_apps/minimal_id/test.js

similarity index 63%

copy from chrome/browser/resources/settings_app/settings_app.js

copy to chrome/test/data/extensions/platform_apps/minimal_id/test.js

index 3385c80fc4f97f0f3a7e3246c2baf5861e8a9f0e..05550ea0393c829e46129bac4fddfaf7da582827 100644

--- a/chrome/browser/resources/settings_app/settings_app.js

+++ b/chrome/test/data/extensions/platform_apps/minimal_id/test.js

@@ -3,8 +3,7 @@

// found in the LICENSE file.

chrome.app.runtime.onLaunched.addListener(function() {

- chrome.app.window.create('chrome://settings-frame/settings', {

- 'height': 550,

- 'width': 640,

- });

+ chrome.app.window.create('main.html',

+ {id: 'minimal_id'},

+ function () {});

benwells 2012/10/24 03:24:08 Nit: You don't need the callback.

tapted 2012/10/24 04:03:57 Done.

});

« chrome/browser/extensions/platform_app_browsertest.cc ('K') | « chrome/test/data/extensions/platform_apps/minimal_id/manifest.json ('k') | no next file » | no next file with comments »