Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: utils/apidoc/html_diff.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « utils/apidoc/apidoc.dart ('k') | utils/archive/options.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/apidoc/html_diff.dart
diff --git a/utils/apidoc/html_diff.dart b/utils/apidoc/html_diff.dart
index 4ef3248e5d41da15919bd354b298ac1085753de2..c5fd28f7a3bfcfecc6717de42eb70a9340e0657c 100644
--- a/utils/apidoc/html_diff.dart
+++ b/utils/apidoc/html_diff.dart
@@ -103,7 +103,7 @@ class HtmlDiff {
}
for (InterfaceMirror htmlType in htmlLib.types.getValues()) {
final domTypes = htmlToDomTypes(htmlType);
- if (domTypes.isEmpty()) continue;
+ if (domTypes.isEmpty) continue;
htmlTypesToDom.putIfAbsent(htmlType.qualifiedName,
() => new Set()).addAll(domTypes);
@@ -121,7 +121,7 @@ class HtmlDiff {
*/
void _addMemberDiff(MemberMirror htmlMember, List<String> domTypes) {
var domMembers = htmlToDomMembers(htmlMember, domTypes);
- if (htmlMember == null && !domMembers.isEmpty()) {
+ if (htmlMember == null && !domMembers.isEmpty) {
warn('$HTML_LIBRARY_NAME member '
'${htmlMember.surroundingDeclaration.simpleName}.'
'${htmlMember.simpleName} has no corresponding '
@@ -129,7 +129,7 @@ class HtmlDiff {
}
if (htmlMember == null) return;
- if (!domMembers.isEmpty()) {
+ if (!domMembers.isEmpty) {
htmlToDom[htmlMember.qualifiedName] = domMembers;
}
}
@@ -172,7 +172,7 @@ class HtmlDiff {
final members = new Set();
domNames.forEach((name) {
var nameMembers = _membersFromName(name, domTypes);
- if (nameMembers.isEmpty()) {
+ if (nameMembers.isEmpty) {
if (name.contains('.')) {
warn('no member $name');
} else {
@@ -202,7 +202,7 @@ class HtmlDiff {
*/
Set<String> _membersFromName(String name, List<String> defaultTypes) {
if (!name.contains('.', 0)) {
- if (defaultTypes.isEmpty()) {
+ if (defaultTypes.isEmpty) {
warn('no default type for $name');
return new Set();
}
« no previous file with comments | « utils/apidoc/apidoc.dart ('k') | utils/archive/options.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698