Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: utils/apidoc/apidoc.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/standalone.status ('k') | utils/apidoc/html_diff.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/apidoc/apidoc.dart
diff --git a/utils/apidoc/apidoc.dart b/utils/apidoc/apidoc.dart
index 693fed3614497ba8dc5dbdf96fc1bf27c2a1c3fa..51ea88bdbd6924fc4b3b740a17ea489d80fc91b8 100644
--- a/utils/apidoc/apidoc.dart
+++ b/utils/apidoc/apidoc.dart
@@ -375,7 +375,7 @@ class Apidoc extends doc.Dartdoc {
String strippedText =
text.replaceAll(const RegExp("@([a-zA-Z]+) ([^;]+)(?:;|\$)"),
'').trim();
- if (strippedText.isEmpty()) return null;
+ if (strippedText.isEmpty) return null;
return super.createDocComment(strippedText, inheritedFrom);
}
@@ -481,7 +481,7 @@ class Apidoc extends doc.Dartdoc {
if (mdnType == null) return null;
if (mdnType['skipped'] != null) return null;
if (mdnType['summary'] == null) return null;
- if (mdnType['summary'].trim().isEmpty()) return null;
+ if (mdnType['summary'].trim().isEmpty) return null;
// Remember which MDN page we're using so we can attribute it.
return new MdnComment(mdnType['summary'], mdnType['srcUrl']);
@@ -531,7 +531,7 @@ class Apidoc extends doc.Dartdoc {
if (mdnMember == null) return null;
if (mdnMember['help'] == null) return null;
- if (mdnMember['help'].trim().isEmpty()) return null;
+ if (mdnMember['help'].trim().isEmpty) return null;
// Remember which MDN page we're using so we can attribute it.
return new MdnComment(mdnMember['help'], mdnType['srcUrl']);
« no previous file with comments | « tests/standalone/standalone.status ('k') | utils/apidoc/html_diff.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698