Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: lib/compiler/implementation/universe/selector_map.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/universe/selector_map.dart
diff --git a/lib/compiler/implementation/universe/selector_map.dart b/lib/compiler/implementation/universe/selector_map.dart
index b5aa0d24880590e6fbaf4d68671dcf61c6d70e45..b1861ebcbc71b9de53744407d47427c31693cb5a 100644
--- a/lib/compiler/implementation/universe/selector_map.dart
+++ b/lib/compiler/implementation/universe/selector_map.dart
@@ -14,7 +14,7 @@ class SelectorMap<T> extends PartialTypeTree {
if (node == null) return null;
Link<SelectorValue<T>> selectors = node.selectorsByName[selector.name];
if (selectors == null) return null;
- for (Link link = selectors; !link.isEmpty(); link = link.tail) {
+ for (Link link = selectors; !link.isEmpty; link = link.tail) {
SelectorValue<T> existing = link.head;
if (existing.selector.equalsUntyped(selector)) return existing.value;
}
@@ -33,7 +33,7 @@ class SelectorMap<T> extends PartialTypeTree {
} else {
// Run through the linked list of selectors with the same name. If
// we find one that matches, we update the value in the mapping.
- for (Link link = selectors; !link.isEmpty(); link = link.tail) {
+ for (Link link = selectors; !link.isEmpty; link = link.tail) {
SelectorValue<T> existing = link.head;
// It is safe to ignore the type here, because all selector
// mappings that are stored in a single node have the same type.
@@ -55,7 +55,7 @@ class SelectorMap<T> extends PartialTypeTree {
if (node == null) return false;
Link<SelectorValue<T>> selectors = node.selectorsByName[selector.name];
if (selectors == null) return false;
- for (Link link = selectors; !link.isEmpty(); link = link.tail) {
+ for (Link link = selectors; !link.isEmpty; link = link.tail) {
SelectorValue<T> existing = link.head;
if (existing.selector.equalsUntyped(selector)) return true;
}
@@ -83,7 +83,7 @@ class SelectorMap<T> extends PartialTypeTree {
root.visitRecursively((SelectorMapNode<T> node) {
Link<SelectorValue<T>> selectors = node.selectorsByName[member.name];
if (selectors == null) return true;
- for (Link link = selectors; !link.isEmpty(); link = link.tail) {
+ for (Link link = selectors; !link.isEmpty; link = link.tail) {
SelectorValue<T> existing = link.head;
Selector selector = existing.selector;
// Since we're running through the entire tree we have to use
@@ -100,7 +100,7 @@ class SelectorMap<T> extends PartialTypeTree {
visitHierarchy(member.getEnclosingClass(), (SelectorMapNode<T> node) {
Link<SelectorValue<T>> selectors = node.selectorsByName[member.name];
if (selectors == null) return true;
- for (Link link = selectors; !link.isEmpty(); link = link.tail) {
+ for (Link link = selectors; !link.isEmpty; link = link.tail) {
SelectorValue<T> existing = link.head;
Selector selector = existing.selector;
if (selector.appliesUntyped(member, compiler)) {
« no previous file with comments | « lib/compiler/implementation/universe/partial_type_tree.dart ('k') | lib/compiler/implementation/universe/universe.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698