Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Unified Diff: lib/compiler/implementation/ssa/validate.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/validate.dart
diff --git a/lib/compiler/implementation/ssa/validate.dart b/lib/compiler/implementation/ssa/validate.dart
index 94bc1369bf2cf52d61bc8068e1c93523dbc13898..aa44966ea54d02ef60393c133449d8f4cde13d9b 100644
--- a/lib/compiler/implementation/ssa/validate.dart
+++ b/lib/compiler/implementation/ssa/validate.dart
@@ -46,14 +46,14 @@ class HValidator extends HInstructionVisitor {
(block.successors.length != 1 || !block.successors[0].isExitBlock())) {
markInvalid("Return node with > 1 succesor or not going to exit-block");
}
- if (block.last is HExit && !block.successors.isEmpty()) {
+ if (block.last is HExit && !block.successors.isEmpty) {
markInvalid("Exit block with successor");
}
- if (block.last is HThrow && !block.successors.isEmpty()) {
+ if (block.last is HThrow && !block.successors.isEmpty) {
markInvalid("Throw block with successor");
}
- if (block.successors.isEmpty() &&
+ if (block.successors.isEmpty &&
block.last is !HThrow &&
!block.isExitBlock()) {
markInvalid("Non-exit or throw block without successor");
« no previous file with comments | « lib/compiler/implementation/ssa/types_propagation.dart ('k') | lib/compiler/implementation/ssa/value_set.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698