Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: lib/compiler/implementation/ssa/bailout.dart

Issue 11238035: Make isEmpty a getter. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update status file with co19 issue number. Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/scanner/token.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/ssa/bailout.dart
diff --git a/lib/compiler/implementation/ssa/bailout.dart b/lib/compiler/implementation/ssa/bailout.dart
index af15533595027f7c8954204289fdef0036f01245..9e06f5964ae7c568a25da3f1d25cc866d8e0d2ef 100644
--- a/lib/compiler/implementation/ssa/bailout.dart
+++ b/lib/compiler/implementation/ssa/bailout.dart
@@ -59,7 +59,7 @@ class Environment {
loopMarkers.addAll(other.loopMarkers);
}
- bool isEmpty() => lives.isEmpty() && loopMarkers.isEmpty();
+ bool get isEmpty => lives.isEmpty && loopMarkers.isEmpty;
}
@@ -263,7 +263,7 @@ class SsaEnvironmentBuilder extends HBaseVisitor implements OptimizationPhase {
void visitGraph(HGraph graph) {
visitPostDominatorTree(graph);
- if (!liveInstructions[graph.entry].isEmpty()) {
+ if (!liveInstructions[graph.entry].isEmpty) {
compiler.internalError('Bailout environment computation',
node: compiler.currentElement.parseNode(compiler));
}
@@ -417,7 +417,7 @@ class SsaBailoutPropagator extends HBaseVisitor {
void visitGraph(HGraph graph) {
subGraph = new SubGraph(graph.entry, graph.exit);
visitBasicBlock(graph.entry);
- if (!blocks.isEmpty()) {
+ if (!blocks.isEmpty) {
compiler.internalError('Bailout propagation',
node: compiler.currentElement.parseNode(compiler));
}
@@ -430,7 +430,7 @@ class SsaBailoutPropagator extends HBaseVisitor {
if (block.isLoopHeader()) {
blocks.addLast(block);
} else if (block.isLabeledBlock()
- && (blocks.isEmpty() || !identical(blocks.last(), block))) {
+ && (blocks.isEmpty || !identical(blocks.last(), block))) {
HLabeledBlockInformation info = block.blockFlow.body;
visitStatements(info.body);
return;
@@ -530,7 +530,7 @@ class SsaBailoutPropagator extends HBaseVisitor {
if (inputLength > maxBailoutParameters) {
maxBailoutParameters = inputLength;
}
- if (blocks.isEmpty()) {
+ if (blocks.isEmpty) {
if (firstBailoutTarget == null) {
firstBailoutTarget = target;
} else {
« no previous file with comments | « lib/compiler/implementation/scanner/token.dart ('k') | lib/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698