chrome/test/base/testing_profile.cc - Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/base/testing_profile.cc

Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Removed superflous empty line. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/base/testing_profile.cc

diff --git a/chrome/test/base/testing_profile.cc b/chrome/test/base/testing_profile.cc

index 63eab1b5640d4241d6d69afacbdde8714495f23d..ca4efc7ad927bcc1ebb632ac4ff36ec90fe6de82 100644

--- a/chrome/test/base/testing_profile.cc

+++ b/chrome/test/base/testing_profile.cc

@@ -784,8 +784,12 @@ chrome_browser_net::Predictor* TestingProfile::GetNetworkPredictor() {

return NULL;

}

-void TestingProfile::ClearNetworkingHistorySince(base::Time time) {

- NOTIMPLEMENTED();

+void TestingProfile::ClearNetworkingHistorySince(

+ base::Time time,

+ const base::Closure& completion) {

+ if (!completion.is_null()) {

+ BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, completion);

mmenke 2012/10/25 20:15:52 IMPORTANT: The completion should be run on the UI

engedy 2012/10/25 21:47:43 Duh! Thanks for spotting that.

+ }

}

GURL TestingProfile::GetHomePage() {

« chrome/browser/profiles/profile_impl_io_data.h ('K') | « chrome/test/base/testing_profile.h ('k') | no next file » | no next file with comments »