Added completion notification to Profile's ClearNetworkingHistorySince.

chrome/browser/profiles/profile_impl_io_data.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PROFILES_PROFILE_IMPL_IO_DATA_H_
 #define CHROME_BROWSER_PROFILES_PROFILE_IMPL_IO_DATA_H_
 
 #include "base/basictypes.h"
 #include "base/callback.h"
 #include "base/hash_tables.h"
@@ skipping 53 matching lines @@
         GetMediaRequestContextGetter() const;
     scoped_refptr<ChromeURLRequestContextGetter>
         GetExtensionsRequestContextGetter() const;
     scoped_refptr<ChromeURLRequestContextGetter>
         GetIsolatedAppRequestContextGetter(
             const std::string& app_id) const;
     scoped_refptr<ChromeURLRequestContextGetter>
         GetIsolatedMediaRequestContextGetter(
             const std::string& app_id) const;
 
-    void ClearNetworkingHistorySince(base::Time time);
+    void ClearNetworkingHistorySince(base::Time time,
+                                     const base::Closure& completion);

[mmenke, 2012/10/25 20:15:52]

Think you should mention that |completion| will be called on the UI thread here.
 This behavior is non-obvious from looking at this class.  Admittedly, it's
mentioned in the other two classes, and not a whole lot of classes actually have
access to this class, but I'm paranoid.

[engedy, 2012/10/25 21:47:43]

I agree. I copied the comment from profile.h and also added it on line 171.

 
    private:
     typedef base::hash_map<std::string,
                            scoped_refptr<ChromeURLRequestContextGetter> >
         ChromeURLRequestContextGetterMap;
 
     // Lazily initialize ProfileParams. We do this on the calls to
     // Get*RequestContextGetter(), so we only initialize ProfileParams right
     // before posting a task to the IO thread to start using them. This prevents
     // objects that are supposed to be deleted on the IO thread, but are created
@@ skipping 76 matching lines @@
       IOThread::Globals* io_thread_globals) const OVERRIDE;
 
   void SetUpJobFactory(net::URLRequestJobFactory* job_factory,
                        scoped_ptr<net::URLRequestJobFactory::Interceptor>
                            protocol_handler_interceptor,
                        net::NetworkDelegate* network_delegate,
                        net::FtpTransactionFactory* ftp_transaction_factory,
                        net::FtpAuthCache* ftp_auth_cache) const;
 
   // Clears the networking history since |time|.
-  void ClearNetworkingHistorySinceOnIOThread(base::Time time);
+  void ClearNetworkingHistorySinceOnIOThread(base::Time time,
+                                             const base::Closure& completion);
 
   // Lazy initialization params.
   mutable scoped_ptr<LazyParams> lazy_params_;
 
   mutable scoped_ptr<net::HttpTransactionFactory> main_http_factory_;
   mutable scoped_ptr<net::FtpTransactionFactory> ftp_factory_;
 
   mutable scoped_ptr<chrome_browser_net::Predictor> predictor_;
 
   mutable scoped_ptr<ChromeURLRequestContext> media_request_context_;
 
   mutable scoped_ptr<net::URLRequestJobFactory> main_job_factory_;
   mutable scoped_ptr<net::URLRequestJobFactory> extensions_job_factory_;
 
   // Parameters needed for isolated apps.
   FilePath profile_path_;
   int app_cache_max_size_;
   int app_media_cache_max_size_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileImplIOData);
 };
 
 #endif  // CHROME_BROWSER_PROFILES_PROFILE_IMPL_IO_DATA_H_