content/renderer/devtools/v8_sampling_profiler_browsertest.cc - Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/accessibility/renderer_accessibility_browsertest.cc ('k') | content/renderer/render_view_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/devtools/v8_sampling_profiler_browsertest.cc

diff --git a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

index aacd305d03f42c02bf4b8bf9aa1f3f3eb475d37a..db3c8d5f7ae5bb9d933e3a4f345b272e1359b104 100644

--- a/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

+++ b/content/renderer/devtools/v8_sampling_profiler_browsertest.cc

@@ -30,7 +30,7 @@ class V8SamplingProfilerTest : public RenderViewTest {

RenderViewTest::TearDown();

}

- void KickV8() { ExecuteJavaScript("1"); }

+ void KickV8() { ExecuteJavaScriptForTests("1"); }

void SyncFlush(TraceLog* trace_log) {

base::WaitableEvent flush_complete_event(false, false);