content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java - Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/ContentViewLocationTest.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java

index 3f2ad52832fbac78033a0edb4152915103d1aff3..c835211050f0216c2ee3d26968593053a3be1fa3 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBareboneTest.java

@@ -40,7 +40,7 @@ public class JavaBridgeBareboneTest extends ContentShellTestBase {

private String evaluateJsSync(String jsCode) throws Exception {

OnEvaluateJavaScriptResultHelper javascriptHelper = new OnEvaluateJavaScriptResultHelper();

- javascriptHelper.evaluateJavaScript(getWebContents(), jsCode);

+ javascriptHelper.evaluateJavaScriptForTests(getWebContents(), jsCode);

javascriptHelper.waitUntilHasValue();

return javascriptHelper.getJsonResultAndClear();

}