Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
diff --git a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
index 5be1f9253d32d5aac42c3c6acece73445272f66b..5dad2d6a5848488d5f6b2a65e3bfb5736a56ed8d 100644
--- a/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
+++ b/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
@@ -218,16 +218,31 @@ public interface WebContents extends Parcelable {
* Injects the passed Javascript code in the current page and evaluates it.
* If a result is required, pass in a callback.
*
+ * It is not possible to use this method to evaluate JavaScript on web
+ * content, only on WebUI pages.
+ *
* @param script The Javascript to execute.
* @param callback The callback to be fired off when a result is ready. The script's
* result will be json encoded and passed as the parameter, and the call
* will be made on the main thread.
* If no result is required, pass null.
*/
- @VisibleForTesting
void evaluateJavaScript(String script, JavaScriptCallback callback);
/**
+ * Injects the passed Javascript code in the current page and evaluates it.
+ * If a result is required, pass in a callback.
+ *
+ * @param script The Javascript to execute.
+ * @param callback The callback to be fired off when a result is ready. The script's
+ * result will be json encoded and passed as the parameter, and the call
+ * will be made on the main thread.
+ * If no result is required, pass null.
+ */
+ @VisibleForTesting
+ void evaluateJavaScriptForTests(String script, JavaScriptCallback callback);
+
+ /**
* Adds a log message to dev tools console. |level| must be a value of
* org.chromium.content_public.common.ConsoleMessageLevel.
*/

Powered by Google App Engine
This is Rietveld 408576698