chrome/renderer/autofill/password_generation_agent_browsertest.cc - Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/autofill/password_generation_agent_browsertest.cc

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/dom_distiller/content/browser/distiller_page_web_contents_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/autofill/password_generation_agent_browsertest.cc

diff --git a/chrome/renderer/autofill/password_generation_agent_browsertest.cc b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

index 731d7c072aeea4b8103fe2ae56095273d9f6e953..3fc06a1e87b108a1d2120bc759a471b8e652fc74 100644

--- a/chrome/renderer/autofill/password_generation_agent_browsertest.cc

+++ b/chrome/renderer/autofill/password_generation_agent_browsertest.cc

@@ -51,7 +51,7 @@ class PasswordGenerationAgentTest : public ChromeRenderViewTest {

blink::WebElement element =

document.getElementById(blink::WebString::fromUTF8(element_id));

ASSERT_FALSE(element.isNull());

- ExecuteJavaScript(

+ ExecuteJavaScriptForTests(

base::StringPrintf("document.getElementById('%s').focus();",

element_id).c_str());

}

@@ -418,12 +418,13 @@ TEST_F(PasswordGenerationAgentTest, MaximumOfferSize) {

// Change focus. Bubble should be hidden, but that is handled by AutofilAgent,

// so no messages are sent.

- ExecuteJavaScript("document.getElementById('username').focus();");

+ ExecuteJavaScriptForTests("document.getElementById('username').focus();");

EXPECT_EQ(0u, password_generation_->messages().size());

password_generation_->clear_messages();

// Focusing the password field will bring up the generation UI again.

- ExecuteJavaScript("document.getElementById('first_password').focus();");

+ ExecuteJavaScriptForTests(

+ "document.getElementById('first_password').focus();");

ASSERT_EQ(1u, password_generation_->messages().size());

EXPECT_EQ(AutofillHostMsg_ShowPasswordGenerationPopup::ID,

password_generation_->messages()[0]->type());

@@ -443,7 +444,7 @@ TEST_F(PasswordGenerationAgentTest, DynamicFormTest) {

LoadHTMLWithUserGesture(kSigninFormHTML);

SetNotBlacklistedMessage(password_generation_, kSigninFormHTML);

- ExecuteJavaScript(

+ ExecuteJavaScriptForTests(

"var form = document.createElement('form');"

"var username = document.createElement('input');"

"username.type = 'text';"