chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 59c36a804fa97f9b3beaebb407db36314a931605..19b1715499eac43aaf79c7c192ec06cfe6a717d6 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -568,7 +568,7 @@ class SafeBrowsingBlockingPageBrowserTest

// We don't use ExecuteScriptAndGetValue for this one, since clicking

// the button/link may navigate away before the injected javascript can

// reply, hanging the test.

- rvh->GetMainFrame()->ExecuteJavaScript(

+ rvh->GetMainFrame()->ExecuteJavaScriptForTests(

base::ASCIIToUTF16(

"document.getElementById('" + node_id + "').click();\n"));

return true;

« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/task_manager/task_manager_browsertest.cc » ('j') | no next file with comments »