chrome/browser/extensions/alert_apitest.cc - Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/alert_apitest.cc

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/errorpage_browsertest.cc ('k') | chrome/browser/extensions/api/media_galleries/media_galleries_watch_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/alert_apitest.cc

diff --git a/chrome/browser/extensions/alert_apitest.cc b/chrome/browser/extensions/alert_apitest.cc

index 9aece0353b4423463cb74a3ae8747582cf5e790a..753f149a0ed868fb6f4987114382467611458969 100644

--- a/chrome/browser/extensions/alert_apitest.cc

+++ b/chrome/browser/extensions/alert_apitest.cc

@@ -21,7 +21,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, AlertBasic) {

extensions::ProcessManager::Get(browser()->profile())

->GetBackgroundHostForExtension(extension->id());

ASSERT_TRUE(host);

- host->host_contents()->GetMainFrame()->ExecuteJavaScript(

+ host->host_contents()->GetMainFrame()->ExecuteJavaScriptForTests(

base::ASCIIToUTF16("alert('This should not crash.');"));

app_modal::AppModalDialog* alert = ui_test_utils::WaitForAppModalDialog();