Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3070)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java

Issue 1123783002: Add ExecuteJavaScriptForTest and make all tests use it (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
index 98f45f7a8b82093c6f8b131f04efd376241ae023..23beb13d4c46263b9a43be37faf396fdbf798c93 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/GeolocationTest.java
@@ -113,7 +113,7 @@ public class GeolocationTest extends AwTestBase {
loadDataSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
RAW_HTML, "text/html", false);
- mAwContents.evaluateJavaScript("initiate_getCurrentPosition();", null);
+ mAwContents.evaluateJavaScriptForTests("initiate_getCurrentPosition();", null);
poll(new Callable<Boolean>() {
@Override
@@ -122,7 +122,7 @@ public class GeolocationTest extends AwTestBase {
}
});
- mAwContents.evaluateJavaScript("initiate_getCurrentPosition();", null);
+ mAwContents.evaluateJavaScriptForTests("initiate_getCurrentPosition();", null);
poll(new Callable<Boolean>() {
@Override
public Boolean call() throws Exception {
@@ -140,7 +140,7 @@ public class GeolocationTest extends AwTestBase {
loadDataSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
RAW_HTML, "text/html", false);
- mAwContents.evaluateJavaScript("initiate_watchPosition();", null);
+ mAwContents.evaluateJavaScriptForTests("initiate_watchPosition();", null);
poll(new Callable<Boolean>() {
@Override
@@ -157,7 +157,7 @@ public class GeolocationTest extends AwTestBase {
loadDataSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
RAW_HTML, "text/html", false);
- mAwContents.evaluateJavaScript("initiate_watchPosition();", null);
+ mAwContents.evaluateJavaScriptForTests("initiate_watchPosition();", null);
poll(new Callable<Boolean>() {
@Override
@@ -215,7 +215,7 @@ public class GeolocationTest extends AwTestBase {
loadDataSync(mAwContents, mContentsClient.getOnPageFinishedHelper(),
RAW_HTML, "text/html", false);
- mAwContents.evaluateJavaScript("initiate_watchPosition();", null);
+ mAwContents.evaluateJavaScriptForTests("initiate_watchPosition();", null);
assertEquals(0, getPositionCountFromJS());

Powered by Google App Engine
This is Rietveld 408576698