Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123743007: DM: add draw_to_canvas() to trim some boilerplate for Vias. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: add draw_to_canvas() to trim some boilerplate for Vias. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a16e69ec6ccbaf81671f66ee77ca3b0c07100041

Patch Set 1 #

Patch Set 2 : Android too #

Patch Set 3 : Don't mess with Android. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -150 lines) Patch
M dm/DMSrcSink.cpp View 8 chunks +112 lines, -150 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123743007/20001
5 years, 7 months ago (2015-05-05 17:38:23 UTC) #2
mtklein
5 years, 7 months ago (2015-05-05 17:46:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123743007/40001
5 years, 7 months ago (2015-05-05 17:48:05 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-05 17:58:14 UTC) #8
reed1
less is more lgtm
5 years, 7 months ago (2015-05-05 18:37:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123743007/40001
5 years, 7 months ago (2015-05-05 18:38:33 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 18:38:49 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/a16e69ec6ccbaf81671f66ee77ca3b0c07100041

Powered by Google App Engine
This is Rietveld 408576698