Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 1123743006: Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188… (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/11188… (patchset #2 id:20001 of https://codereview.chromium.org/1122813002/) Reason for revert: did not update DeferredCanvas Original issue's description: > Make drawImage a virtual on SkDevice (patchset #3 id:40001 of https://codereview.chromium.org/1118823004/)" > > Fixed serialization from prev CL > > This reverts commit 973d1f1f60f2710a268a3165aa4f3460502d4be5. > > BUG=skia:3803 > TBR= > > Committed: https://skia.googlesource.com/skia/+/5392785080001fe737fac9e5801fc2127a78d4fb TBR= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3803 Committed: https://skia.googlesource.com/skia/+/119468b71f8f4f45657ab30ead331be665de5a57

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -138 lines) Patch
M include/core/SkDevice.h View 1 chunk +0 lines, -4 lines 0 comments Download
M include/core/SkImage.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +5 lines, -51 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +0 lines, -17 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/image/SkImage_Base.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/image/SkImage_Gpu.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/image/SkImage_Raster.cpp View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
reed1
5 years, 7 months ago (2015-05-05 12:41:30 UTC) #1
Created Revert of Make drawImage a virtual on SkDevice (patchset #3 id:40001 of
https://codereview.chromium.org/11188…

Powered by Google App Engine
This is Rietveld 408576698