Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1123723003: [c++11] Remove remnants of pre-C++11 delete, final and override. (Closed)

Created:
5 years, 7 months ago by Benedikt Meurer
Modified:
5 years, 7 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[c++11] Remove remnants of pre-C++11 delete, final and override. These macros are not needed anymore, so there's no point in supporting them. Committed: https://crrev.com/64d73404393f25e2ba3a2b80106bdca2dcb95fe9 Cr-Commit-Position: refs/heads/master@{#28214}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -37 lines) Patch
M include/v8config.h View 6 chunks +0 lines, -32 lines 0 comments Download
M src/base/macros.h View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Benedikt Meurer
Hey Michael, These are macros from the pre-C++11 area, which are no longer used. Trivial ...
5 years, 7 months ago (2015-05-05 07:12:28 UTC) #2
Michael Achenbach
lgtm
5 years, 7 months ago (2015-05-05 07:15:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123723003/1
5 years, 7 months ago (2015-05-05 07:19:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 07:44:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 07:44:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/64d73404393f25e2ba3a2b80106bdca2dcb95fe9
Cr-Commit-Position: refs/heads/master@{#28214}

Powered by Google App Engine
This is Rietveld 408576698