Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1123723002: [chrome/browser/chromeos] ui::ResourceBundle::GetSharedInstance should return a pointer (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modification in chrome/browser/chromeos module, Instead of writting: ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance(); It should be rewritting to look like: ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance(); Also function calls should be modified accordingly.. BUG=289640 Committed: https://crrev.com/a700384e6d64edb24f59af8168b0951c5082cbe2 Cr-Commit-Position: refs/heads/master@{#328147}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_external_updater.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ui/idle_app_name_notification_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/ui/kiosk_external_update_notification.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-04 09:59:54 UTC) #2
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-04 10:01:22 UTC) #5
xiyuan
lgtm
5 years, 7 months ago (2015-05-04 16:01:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123723002/1
5 years, 7 months ago (2015-05-04 17:27:49 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 18:01:31 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 18:04:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a700384e6d64edb24f59af8168b0951c5082cbe2
Cr-Commit-Position: refs/heads/master@{#328147}

Powered by Google App Engine
This is Rietveld 408576698