src/api.cc - Issue 1123703002: Reland "Wrap v8natives.js into a function."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1123703002: Reland "Wrap v8natives.js into a function." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: revert stack trace printing Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 46b8a52fd6fa0c311a828b5f5db73d673fc38bd0..9986df8bf2dd399a8ed836af7b6b353a5221d59c 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -3589,7 +3589,7 @@ MaybeLocal<Value> v8::Object::GetOwnPropertyDescriptor(Local<Context> context,

i::Handle<i::Object> args[] = { obj, key_name };

i::Handle<i::Object> result;

has_pending_exception =

- !CallV8HeapFunction(isolate, "ObjectGetOwnPropertyDescriptor",

+ !CallV8HeapFunction(isolate, "$objectGetOwnPropertyDescriptor",

isolate->factory()->undefined_value(),

arraysize(args), args).ToHandle(&result);

RETURN_ON_FAILED_EXECUTION(Value);

« no previous file with comments | « no previous file | src/array.js » ('j') | no next file with comments »