Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1123643007: Restore aura support from Mojo repo. (Closed)

Created:
5 years, 7 months ago by Ben Goodger (Google)
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, yzshen+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, piman+watch_chromium.org, kalyank, darin (slow to review), sievers+watch_chromium.org, ben+mojo_chromium.org, danakj+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Restore aura support from Mojo repo. This is mostly a straight restore into mandoline/ui/aura (combined the needed views files in there) but had to bring a few things up to date with the state of Mojo SDK now, e.g. declienting etc. R=sky@chromium.org BUG= Committed: https://crrev.com/790a612290f8c0c4245f7cfd1a4701ccf259b59b Cr-Commit-Position: refs/heads/master@{#328290}

Patch Set 1 #

Patch Set 2 : , #

Patch Set 3 : . #

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1246 lines, -6 lines) Patch
M mandoline/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + mandoline/ui/BUILD.gn View 1 chunk +4 lines, -6 lines 0 comments Download
A mandoline/ui/aura/BUILD.gn View 1 chunk +56 lines, -0 lines 0 comments Download
A mandoline/ui/aura/DEPS View 1 chunk +19 lines, -0 lines 0 comments Download
A mandoline/ui/aura/aura_init.h View 1 chunk +28 lines, -0 lines 0 comments Download
A mandoline/ui/aura/aura_init.cc View 1 chunk +62 lines, -0 lines 0 comments Download
A mandoline/ui/aura/input_method_mojo_linux.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A mandoline/ui/aura/input_method_mojo_linux.cc View 1 chunk +43 lines, -0 lines 0 comments Download
A mandoline/ui/aura/native_widget_view_manager.h View 1 chunk +70 lines, -0 lines 0 comments Download
A mandoline/ui/aura/native_widget_view_manager.cc View 1 2 1 chunk +164 lines, -0 lines 0 comments Download
A mandoline/ui/aura/screen_mojo.h View 1 chunk +49 lines, -0 lines 0 comments Download
A mandoline/ui/aura/screen_mojo.cc View 1 chunk +71 lines, -0 lines 0 comments Download
A mandoline/ui/aura/surface_binding.h View 1 chunk +48 lines, -0 lines 0 comments Download
A mandoline/ui/aura/surface_binding.cc View 1 2 3 1 chunk +253 lines, -0 lines 0 comments Download
A mandoline/ui/aura/surface_context_factory.h View 1 chunk +48 lines, -0 lines 0 comments Download
A mandoline/ui/aura/surface_context_factory.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A mandoline/ui/aura/window_tree_host_mojo.h View 1 chunk +75 lines, -0 lines 0 comments Download
A mandoline/ui/aura/window_tree_host_mojo.cc View 1 chunk +117 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Ben Goodger (Google)
5 years, 7 months ago (2015-05-04 22:54:27 UTC) #1
sky
Rubber stamp LGTM
5 years, 7 months ago (2015-05-04 22:55:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123643007/40001
5 years, 7 months ago (2015-05-04 23:53:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/85104)
5 years, 7 months ago (2015-05-05 00:08:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123643007/60001
5 years, 7 months ago (2015-05-05 06:13:50 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-05 06:43:03 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 06:43:52 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/790a612290f8c0c4245f7cfd1a4701ccf259b59b
Cr-Commit-Position: refs/heads/master@{#328290}

Powered by Google App Engine
This is Rietveld 408576698