Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1123643004: win: Fix multiple definition at link time for kSignature (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

win: Fix multiple definition at link time for kSignature I'm not sure why I don't get these locally, but the bots aren't happy: https://build.chromium.org/p/client.crashpad/builders/crashpad_win_dbg/builds/271/steps/compile%20with%20ninja/logs/stdio FAILED: E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True crashpad_snapshot_test_module.dll "E:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /IMPLIB:crashpad_snapshot_test_module.dll.lib /DLL /OUT:crashpad_snapshot_test_module.dll @crashpad_snapshot_test_module.dll.rsp" 2 mt.exe rc.exe "obj\snapshot\crashpad_snapshot_test_module.crashpad_snapshot_test_module.dll.intermediate.manifest" obj\snapshot\crashpad_snapshot_test_module.crashpad_snapshot_test_module.dll.generated.manifest crashpad_client.lib(crashpad_client.crashpad_info.obj) : error LNK2005: "public: static unsigned int const crashpad::CrashpadInfo::kSignature" (?kSignature@CrashpadInfo@crashpad@@2IB) already defined in crashpad_snapshot_test_module.crashpad_info_client_options_test_module.obj R=mark@chromium.org BUG=crashpad:1 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/720882cc14d0542f1d57a0ec7d5434ff7987bfd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M client/crashpad_info.h View 1 chunk +3 lines, -1 line 0 comments Download
M client/crashpad_info.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
5 years, 7 months ago (2015-05-04 21:18:50 UTC) #1
Mark Mentovai
Weird. Adding “inline” may also help too.
5 years, 7 months ago (2015-05-04 21:32:49 UTC) #2
Mark Mentovai
LGTM to fix it though.
5 years, 7 months ago (2015-05-04 21:32:56 UTC) #3
scottmg
5 years, 7 months ago (2015-05-04 23:02:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
720882cc14d0542f1d57a0ec7d5434ff7987bfd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698