Chromium Code Reviews
Help | Chromium Project | Sign in
(102)

Issue 11236042: ninja windows: add flag support for code analysis (aka PREfast) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by scottmg
Modified:
1 year, 5 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: add flag support for code analysis (aka PREfast)

Also add test for same for both MSVS and ninja. This test is
only enabled on VS2012 for now. Theoretically, it could be
be enabled for VS2010 Premium too, but few people have that
installed, and we don't currently have a way to gate on that,
so just turn it on for 2012 (non-Express) where it's always
available.
Committed: https://code.google.com/p/gyp/source/detail?r=1522

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : copyright #

Patch Set 5 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Lint Patch
M pylib/gyp/msvs_emulation.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M test/lib/TestGyp.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments 0 errors Download
A test/win/compiler-flags/analysis.gyp View 1 chunk +40 lines, -0 lines 0 comments 0 errors Download
A test/win/compiler-flags/uninit.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments 1 errors Download
A test/win/gyptest-cl-analysis.py View 1 chunk +30 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 5
scottmg
1 year, 5 months ago #1
Evan Martin
this is probably less readable but somehow i feel compelled to comment https://codereview.chromium.org/11236042/diff/2001/test/lib/TestGyp.py File test/lib/TestGyp.py ...
1 year, 5 months ago #2
scottmg
On 2012/10/22 20:31:04, Evan Martin wrote: > this is probably less readable but somehow i ...
1 year, 5 months ago #3
Nico (ooo Apr 18 - Apr 20)
lgtm Do any of the gyp bots have 2012 at all?
1 year, 5 months ago #4
scottmg
1 year, 5 months ago #5
On 2012/10/23 21:06:28, Nico wrote:
> lgtm
> 
> Do any of the gyp bots have 2012 at all?

No, not yet. We just got the first one on chromium.fyi, so this is probably bit
premature, but I just wanted to see what sorts of errors might be interesting.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6