Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 11236042: ninja windows: add flag support for code analysis (aka PREfast) (Closed)

Created:
5 years, 1 month ago by scottmg
Modified:
5 years, 1 month ago
Reviewers:
Nico, Evan Martin
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja windows: add flag support for code analysis (aka PREfast) Also add test for same for both MSVS and ninja. This test is only enabled on VS2012 for now. Theoretically, it could be be enabled for VS2010 Premium too, but few people have that installed, and we don't currently have a way to gate on that, so just turn it on for 2012 (non-Express) where it's always available. Committed: https://code.google.com/p/gyp/source/detail?r=1522

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : copyright #

Patch Set 5 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -2 lines) Patch
M pylib/gyp/msvs_emulation.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M test/lib/TestGyp.py View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
A test/win/compiler-flags/analysis.gyp View 1 chunk +40 lines, -0 lines 0 comments Download
A test/win/compiler-flags/uninit.cc View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A test/win/gyptest-cl-analysis.py View 1 chunk +30 lines, -0 lines 0 comments Download
Trybot results:

Messages

Total messages: 5 (0 generated)
scottmg
5 years, 1 month ago (2012-10-22 19:43:54 UTC) #1
Evan Martin
this is probably less readable but somehow i feel compelled to comment https://codereview.chromium.org/11236042/diff/2001/test/lib/TestGyp.py File test/lib/TestGyp.py ...
5 years, 1 month ago (2012-10-22 20:31:04 UTC) #2
scottmg
On 2012/10/22 20:31:04, Evan Martin wrote: > this is probably less readable but somehow i ...
5 years, 1 month ago (2012-10-22 20:38:42 UTC) #3
Nico
lgtm Do any of the gyp bots have 2012 at all?
5 years, 1 month ago (2012-10-23 21:06:28 UTC) #4
scottmg
5 years, 1 month ago (2012-10-23 21:09:04 UTC) #5
On 2012/10/23 21:06:28, Nico wrote:
> lgtm
> 
> Do any of the gyp bots have 2012 at all?

No, not yet. We just got the first one on chromium.fyi, so this is probably bit
premature, but I just wanted to see what sorts of errors might be interesting.

Powered by Google App Engine
This is Rietveld efc10ee0f