Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3628)

Unified Diff: chrome/browser/nacl_host/nacl_browser.h

Issue 11236025: Test that debug stub works with browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: remove W00 case - it can't happen Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/nacl_browser.h
===================================================================
--- chrome/browser/nacl_host/nacl_browser.h (revision 170891)
+++ chrome/browser/nacl_host/nacl_browser.h (working copy)
@@ -52,6 +52,16 @@
// Returns whether NaCl application with this manifest URL should be debugged.
bool URLMatchesDebugPatterns(GURL manifest_url);
+ // Methods for testing GDB debug stub in browser. If test adds debug stub
+ // port listener, chrome will open ephemeral port for debug stub server
Mark Seaborn 2012/12/05 18:00:47 'chrome' -> 'Chrome'. I don't think "ephemeral" i
halyavin 2012/12/06 15:35:01 Done.
+ // instead of fixed one.
Mark Seaborn 2012/12/05 18:00:47 "a fixed one"
halyavin 2012/12/06 15:35:01 Done.
+
+ // Notify listener that new debug stub TCP port is allocated.
+ void FireGdbDebugStubPortOpened(int port);
+ bool HasGdbDebugStubPortListener();
+ void SetGdbDebugStubPortListener(base::Callback<void(int)> listener);
+ void ClearGdbDebugStubPortListener();
+
bool ValidationCacheIsEnabled() const {
return validation_cache_is_enabled_;
}
@@ -111,6 +121,7 @@
bool validation_cache_is_enabled_;
bool validation_cache_is_modified_;
NaClResourceState validation_cache_state_;
+ base::Callback<void(int)> debug_stub_port_listener_;
bool ok_;
« no previous file with comments | « no previous file | chrome/browser/nacl_host/nacl_browser.cc » ('j') | chrome/browser/nacl_host/nacl_process_host.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698