Test that debug stub works with browser.

chrome/browser/nacl_host/nacl_browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NACL_HOST_NACL_BROWSER_H_
 #define CHROME_BROWSER_NACL_HOST_NACL_BROWSER_H_
 
 #include "base/bind.h"
 #include "base/file_util_proxy.h"
 #include "base/memory/singleton.h"
@@ skipping 34 matching lines @@
 
   // IRT file handle, only available when IsReady().
   base::PlatformFile IrtFile() const;
 
   // Set match patterns which will be checked before enabling debug stub.
   void SetDebugPatterns(std::string debug_patterns);
 
   // Returns whether NaCl application with this manifest URL should be debugged.
   bool URLMatchesDebugPatterns(GURL manifest_url);
 
+  // Send message that new debug stub TCP port is allocated.
+  void DebugStubNewPortAllocated(int port);

[Mark Seaborn, 2012/12/04 21:46:42]

Please group these 4 methods together by removing empty lines between them, and
add a comment that these are used for testing only.

Also rename DebugStubNewPortAllocated so that the name matches up with the
others, e.g. CallDebugStubPortListener().

Also, maybe s/DebugStub/GdbDebugStub/ to make this as obvious as possible to the
uninitiated reader?

[halyavin, 2012/12/05 10:05:57]

Done
I renamed it according to java conventions.
Done

+
+  bool HasDebugStubPortListener();
+
+  void SetDebugStubPortListener(base::Callback<void(int)> listener);
+
+  void ClearDebugStubPortListener();
+
   bool ValidationCacheIsEnabled() const {
     return validation_cache_is_enabled_;
   }
 
   const std::string& GetValidationCacheKey() const {
     return validation_cache_.GetValidationCacheKey();
   }
 
   bool QueryKnownToValidate(const std::string& signature, bool off_the_record);
   void SetKnownToValidate(const std::string& signature, bool off_the_record);
@@ skipping 39 matching lines @@
   FilePath irt_filepath_;
   NaClResourceState irt_state_;
   std::vector<URLPattern> debug_patterns_;
   bool inverse_debug_patterns_;
   NaClValidationCache validation_cache_;
   NaClValidationCache off_the_record_validation_cache_;
   FilePath validation_cache_file_path_;
   bool validation_cache_is_enabled_;
   bool validation_cache_is_modified_;
   NaClResourceState validation_cache_state_;
+  base::Callback<void(int)> debug_stub_port_listener_;
 
   bool ok_;
 
   // A list of pending tasks to start NaCl processes.
   std::vector<base::Closure> waiting_;
 
   DISALLOW_COPY_AND_ASSIGN(NaClBrowser);
 };
 
 #endif  // CHROME_BROWSER_NACL_HOST_NACL_BROWSER_H_