owners.py - Issue 11236018: use "/" instead of path.sep in owners glob check

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: owners.py

Issue 11236018: use "/" instead of path.sep in owners glob check (Closed) Base URL: https://git.chromium.org/chromium/tools/depot_tools.git@master

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: owners.py

diff --git a/owners.py b/owners.py

index e0b4e07b5e9ab2e1c916e104b743982d743a9cc8..5cecdafdaca4307cad5782e02f0bde58ced73e11 100644

--- a/owners.py

+++ b/owners.py

@@ -224,7 +224,7 @@ class Database(object):

glob_string = m.group(1)

directive = m.group(2)

full_glob_string = self.os_path.join(self.root, dirpath, glob_string)

- if self.os_path.sep in glob_string:

+ if '/' in glob_string:

M-A Ruel 2012/10/20 23:05:23 personally, I'd also blacklist '\\' for safety.

raise SyntaxErrorInOwnersFile(owners_path, lineno,

'per-file globs cannot span directories: "%s"' % line)

baselines = self.glob(full_glob_string)

« no previous file with comments | « no previous file | no next file » | no next file with comments »