Add gerrit Change-Id to commit messages if they do not have one.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import json
@@ skipping 21 matching lines @@
 import rietveld
 import scm
 import subprocess2
 import watchlists
 
 
 DEFAULT_SERVER = 'https://codereview.appspot.com'
 POSTUPSTREAM_HOOK_PATTERN = '.git/hooks/post-cl-%s'
 DESCRIPTION_BACKUP_FILE = '~/.git_cl_description_backup'
 GIT_INSTRUCTIONS_URL = 'http://code.google.com/p/chromium/wiki/UsingNewGit'
+CHANGE_ID_STR = 'Change-Id:'

[cmp, 2012/10/20 22:42:31]

drop _STR from variable name (here and below)

[Siva Chandra, 2012/10/22 07:13:56]

Done.

 
 
 # Initialized in main()
 settings = None
 
 
 def DieWithError(message):
   print >> sys.stderr, message
   sys.exit(1)
 
@@ skipping 929 matching lines @@
   else:
     # Default to diffing against the "upstream" branch.
     base_branch = cl.GetUpstreamBranch()
 
   cl.RunHook(committing=not options.upload, upstream_branch=base_branch,
              may_prompt=False, verbose=options.verbose,
              author=None)
   return 0
 
 
+def AddChangeIdToCommitMessage(options, args):
+  """Re-commits using the current message, assumes the commit hook is in
+  place.
+  """
+  log_desc = options.message or CreateDescriptionFromLog(args)
+  git_command = ['commit', '--amend', '-m', log_desc]
+  RunGit(git_command)
+  new_log_desc = CreateDescriptionFromLog(args)
+  if CHANGE_ID_STR in new_log_desc:
+    print "git-cl: Added Change-Id to commit message."

[cmp, 2012/10/20 22:42:31]

use single quotes here rather than double quotes

[Siva Chandra, 2012/10/22 07:13:56]

Done.

+  else:
+    sys.stderr.write("ERROR: Gerrit commit-msg hook not available.\n")

[cmp, 2012/10/20 22:42:31]

use:
  print >>sys.stderr, 'ERROR: Gerrit commit-msg hook not running.'

[Siva Chandra, 2012/10/22 07:13:56]

Done.

+
+
 def GerritUpload(options, args, cl):
   """upload the current branch to gerrit."""
   # We assume the remote called "origin" is the one we want.
   # It is probably not worthwhile to support different workflows.
   remote = 'origin'
   branch = 'master'
   if options.target_branch:
     branch = options.target_branch
 
   log_desc = options.message or CreateDescriptionFromLog(args)
+  if CHANGE_ID_STR not in log_desc:
+    AddChangeIdToCommitMessage(options, args)
   if options.reviewers:
     log_desc += '\nR=' + options.reviewers
   change_desc = ChangeDescription(log_desc, options.reviewers)
   change_desc.ParseDescription()
   if change_desc.IsEmpty():
     print "Description is empty; aborting."
     return 1
 
   receive_options = []
   cc = cl.GetCCList().split(',')
@@ skipping 747 matching lines @@
              'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
   # Not a known command. Default to help.
   GenUsage(parser, 'help')
   return CMDhelp(parser, argv)
 
 
 if __name__ == '__main__':
   fix_encoding.fix_encoding()
   sys.exit(main(sys.argv[1:]))