Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Unified Diff: tests/html/fileapi_test.dart

Issue 11236008: Start a whitelist of methods those optionals should be treated as named formals in dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/html/scripts/generator.py ('K') | « lib/html/scripts/generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/html/fileapi_test.dart
diff --git a/tests/html/fileapi_test.dart b/tests/html/fileapi_test.dart
index f753b013def2a1bceedbebef89288f5c8387aa22..82aad86d6c7074747492cd90cf1fb3430beef33e 100644
--- a/tests/html/fileapi_test.dart
+++ b/tests/html/fileapi_test.dart
@@ -25,7 +25,6 @@ main() {
group('getDirectory', () {
test('directoryDoesntExist', () {
- /* OPTIONALS
fs.root.getDirectory(
'directory2',
options: {},
@@ -35,20 +34,9 @@ main() {
errorCallback: expectAsync1((FileError e) {
expect(e.code, equals(FileError.NOT_FOUND_ERR));
}));
- */
- fs.root.getDirectory(
- 'directory2',
- {},
- (e) {
- fail('Should not be reached');
- },
- expectAsync1((FileError e) {
- expect(e.code, equals(FileError.NOT_FOUND_ERR));
- }));
});
test('directoryCreate', () {
- /* OPTIONALS
fs.root.getDirectory(
'directory3',
options: {'create': true},
@@ -58,23 +46,12 @@ main() {
errorCallback: (e) {
fail('Got file error: ${e.code}');
});
- */
- fs.root.getDirectory(
- 'directory3',
- {'create': true},
- expectAsync1((DirectoryEntry e) {
- expect(e.name, equals('directory3'));
- }),
- (e) {
- fail('Got file error: ${e.code}');
- });
});
});
group('getFile', () {
test('fileDoesntExist', () {
- /* OPTIONALS
fs.root.getFile(
'file2',
options: {},
@@ -84,20 +61,9 @@ main() {
errorCallback: expectAsync1((FileError e) {
expect(e.code, equals(FileError.NOT_FOUND_ERR));
}));
- */
- fs.root.getFile(
- 'file2',
- {},
- (e) {
- fail('Should not be reached');
- },
- expectAsync1((FileError e) {
- expect(e.code, equals(FileError.NOT_FOUND_ERR));
- }));
});
test('fileCreate', () {
- /* OPTIONALS
fs.root.getFile(
'file4',
options: {'create': true},
@@ -109,17 +75,5 @@ main() {
fail('Got file error: ${e.code}');
});
});
- */
- fs.root.getFile(
- 'file4',
- {'create': true},
- expectAsync1((FileEntry e) {
- expect(e.name, equals('file4'));
- expect(e.isFile, equals(true));
- }),
- (e) {
- fail('Got file error: ${e.code}');
- });
- });
});
}
« lib/html/scripts/generator.py ('K') | « lib/html/scripts/generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698