Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1123583002: Add a leak sanitizer suppression for RemoteDOMWindow. (Closed)

Created:
5 years, 7 months ago by dcheng
Modified:
5 years, 7 months ago
CC:
chromium-reviews, site-isolation-reviews_chromium.org, Yuki
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a leak sanitizer suppression for RemoteDOMWindow. In browser tests, LSan seems to think RemoteDOMWindow leaks even though the v8 DOM wrapper is still holding a reference to it. BUG=480676 Committed: https://crrev.com/e6c50d93e65d4c22a8af529137b01ac4223deace Cr-Commit-Position: refs/heads/master@{#328226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/sanitizers/lsan_suppressions.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dcheng
Based on the investigation in https://codereview.chromium.org/1096393005#msg15, I think this is not a real leak. However, ...
5 years, 7 months ago (2015-05-01 21:38:13 UTC) #2
haraken
Thanks for a lot of investigations. I might want to ask opinions of earthdok on ...
5 years, 7 months ago (2015-05-02 02:33:39 UTC) #3
Alexander Potapenko
On 2015/05/02 02:33:39, haraken wrote: > Thanks for a lot of investigations. I might want ...
5 years, 7 months ago (2015-05-04 16:51:57 UTC) #4
haraken
LGTM
5 years, 7 months ago (2015-05-04 22:20:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123583002/1
5 years, 7 months ago (2015-05-04 22:55:29 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 00:11:45 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e6c50d93e65d4c22a8af529137b01ac4223deace Cr-Commit-Position: refs/heads/master@{#328226}
5 years, 7 months ago (2015-05-05 00:13:24 UTC) #9
earthdok
5 years, 7 months ago (2015-05-05 13:53:10 UTC) #10
Message was sent while issue was closed.
On 2015/05/05 00:13:24, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/e6c50d93e65d4c22a8af529137b01ac4223deace
> Cr-Commit-Position: refs/heads/master@{#328226}

lgtm

Powered by Google App Engine
This is Rietveld 408576698