Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 1123573004: Update src/svg to follow C++11 style rule for {virtual,override}. (Closed)

Created:
5 years, 7 months ago by tfarina
Modified:
5 years, 7 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update src/svg to follow C++11 style rule for {virtual,override}. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. The entries were found using the following command line: $ find src/ -iname "*.h" -o -iname "*.cpp" | xargs pcregrep -M "[^\n/]+virtual\ [^;{]+\ [a-zA-Z0-9_]+\([^;{]+\ override[ \n]*[;{]" The regex was a courtesy of nick@chromium.org BUG=None R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/8566539f980ceb32673b843b94acd9e534f06676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -39 lines) Patch
M src/lazy/SkDiscardablePixelRef.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/svg/SkSVGDevice.h View 1 chunk +35 lines, -35 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123573004/1
5 years, 7 months ago (2015-05-03 21:55:14 UTC) #2
tfarina
5 years, 7 months ago (2015-05-03 21:55:33 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-03 21:58:07 UTC) #5
mtklein
lgtm
5 years, 7 months ago (2015-05-04 13:40:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123573004/1
5 years, 7 months ago (2015-05-04 13:40:18 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 13:40:38 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8566539f980ceb32673b843b94acd9e534f06676

Powered by Google App Engine
This is Rietveld 408576698