Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 112353004: Add ExceptionState checks in Document::createElement*() methods. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add ExceptionState checks in Document::createElement*() methods. Check if nested createElement() / createElementNS() calls have reported exceptions and return early if so. Missing in two cases. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M Source/core/dom/Document.cpp View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
please take a look Issue identified via https://codereview.chromium.org/98543011/diff/1/Source/core/dom/Document.cpp#newcode702
7 years ago (2013-12-20 14:11:38 UTC) #1
Mike West
LGTM, thanks!
7 years ago (2013-12-20 14:14:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/112353004/1
7 years ago (2013-12-20 14:21:39 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-20 15:36:08 UTC) #4
Message was sent while issue was closed.
Change committed as 164239

Powered by Google App Engine
This is Rietveld 408576698