Issue 112353002: Move remoting::GetUsername() from remoting/base to remoting/host

Issue 112353002: Move remoting::GetUsername() from remoting/base to remoting/host (Closed)

Created:
7 years ago by Sergey Ulanov

Modified:
7 years ago

Reviewers:
rmsousa

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move remoting::GetUsername() from remoting/base to remoting/host GetUsername() doesn't belong to remoting/base because it's not used by the client. BUG=276739 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240064

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -34 lines)			Patch
M	remoting/base/util.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	remoting/base/util.cc	View		2 chunks	+0 lines, -25 lines	0 comments	Download
M	remoting/host/pam_authorization_factory_posix.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/remoting_me2me_host.cc	View		2 chunks	+1 line, -1 line	0 comments	Download
A	remoting/host/username.h	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download
A	remoting/host/username.cc	View	1 2	1 chunk	+36 lines, -0 lines	0 comments	Download
M	remoting/remoting.gyp	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

rmsousa

https://codereview.chromium.org/112353002/diff/20001/remoting/host/username.cc File remoting/host/username.cc (right): https://codereview.chromium.org/112353002/diff/20001/remoting/host/username.cc#newcode20 remoting/host/username.cc:20: #if defined(OS_ANDROID) Can we remove this #ifdef ANDROID section? ...

7 years ago (2013-12-11 02:20:07 UTC) #2

Sergey Ulanov

7 years ago (2013-12-11 02:22:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/112353002/40001

7 years ago (2013-12-11 04:28:31 UTC) #5

Message was sent while issue was closed.

Change committed as 240064

Expand Messages | Collapse Messages