Issue 11235061: Avoid calling resolveMethodElement from SSA builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11235061: Avoid calling resolveMethodElement from SSA builder. (Closed)

Created:
8 years, 2 months ago by Johnni Winther

Modified:
8 years, 1 month ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid calling resolveMethodElement from SSA builder. Committed: https://code.google.com/p/dart/source/detail?r=14120

Patch Set 2 : Updated cf. comment #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	lib/compiler/implementation/ssa/builder.dart	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM https://codereview.chromium.org/11235061/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11235061/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode994 lib/compiler/implementation/ssa/builder.dart:994: compiler.enqueuer.resolution.getCachedElements(constructor.declaration); Long line.

8 years, 2 months ago (2012-10-23 16:13:24 UTC) #2

Johnni Winther

8 years, 1 month ago (2012-10-26 07:40:02 UTC) #3

https://codereview.chromium.org/11235061/diff/1/lib/compiler/implementation/s...
File lib/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11235061/diff/1/lib/compiler/implementation/s...
lib/compiler/implementation/ssa/builder.dart:994:
compiler.enqueuer.resolution.getCachedElements(constructor.declaration);
On 2012/10/23 16:13:24, ahe wrote:
> Long line.

Done.

Expand Messages | Collapse Messages

Issue 11235061: Avoid calling resolveMethodElement from SSA builder. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Updated cf. comment #

Messages